24 May
2024
24 May
'24
5:08 a.m.
Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81968?usp=email )
Change subject: libpayload: Add x86_64 (64-bit) support ......................................................................
Patch Set 74:
(1 comment)
File payloads/libpayload/arch/x86/pt.S:
https://review.coreboot.org/c/coreboot/+/81968/comment/e5cd69be_c8470729?usp... : PS74, Line 75: mov $(_PRES + _RW + _US + _A + _D), %eax
I still don't understand why you're not setting `_PS` here tbh. […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 74
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Kapil Porwal kapilporwal@google.com
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 24 May 2024 08:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org