Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35168 )
Change subject: soc/intel/skylake: enable GMM in devicetree ......................................................................
Patch Set 3:
(2 comments)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/35168/2/src/soc/intel/skylake/chip_... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35168/2/src/soc/intel/skylake/chip_... PS2, Line 445: dev
Take a look at CB:35173, which should address null pointer derefs on the other device-dependent conf […]
stupid mistake for me :(
https://review.coreboot.org/c/coreboot/+/35168/2/src/soc/intel/skylake/inclu... File src/soc/intel/skylake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35168/2/src/soc/intel/skylake/inclu... PS2, Line 47: SA_DEV_SLOT_IGD
Copypasta error, should be 'SA_DEV_SLOT_GMM'
fixed. Thanks