Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Jianjun Wang.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 )
Change subject: helpers: Add fls support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Isn't this basically just 32 - clz? We already have that (in <lib.h>). Please either just use clz(), or add another static inline there that implements fls() by calling clz().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
Gerrit-Change-Number: 59738
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Nov 2021 23:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment