Attention is currently required from: Henry Sun, Frank Chu, Marco Chen, Zhuohao Lee.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58734 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for convertibles
......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/58734/comment/b1c36fb7_7dacc2ca
PS6, Line 23: return "wifi_sar-galtic.hex";
If WIFI_SAR_CBFS_DEFAULT_FILENAME is wifi_sar-galtic. […]
+1
https://review.coreboot.org/c/coreboot/+/58734/comment/4e67e60f_50751b76
PS6, Line 27: galith
should be gallop? Thanks.
I dont see a specific SAR file for Gallop.
https://review.coreboot.org/c/coreboot/+/58734/comment/6e960f40_e812f800
PS6, Line 32: return "WIFI_SAR_CBFS_DEFAULT_FILENAME";
Where is the CL for new CONFIG_WIFI_SAR_CBFS_FILEPATH? Thanks.
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-ov...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4203d176dd717fa62c88d9b4fab8a53847213fe
Gerrit-Change-Number: 58734
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Mon, 08 Nov 2021 18:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment