Attention is currently required from: Patrick Rudolph, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50329 )
Change subject: sb/intel/lynxpoint/acpi/gpio.asl: Convert to ASL 2.0
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/southbridge/intel/lynxpoint/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/50329/comment/62f3d0a0_9a390388
PS1, Line 80: 48
Since this is a register offset, it makes more sense to keep it in hex.
Done
https://review.coreboot.org/c/coreboot/+/50329/comment/39302737_96abe717
PS1, Line 96: 256
Same here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37d6cf75ee5a5cb2ff92c89178cd4469dc059403
Gerrit-Change-Number: 50329
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 07 Feb 2021 14:54:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment