Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )
Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG@7 PS9, Line 7: support
Capitalize
Done
https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/emi.h:
https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 29: enum
The params will be compiled as C struct and stored as blob, so I think a more explicit type is bette […]
Done
https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 50: int get_dram_type(void);
I think we should not declare this in soc emi.h; instead I think mainboard. […]
the DDR driver get the dram type first for DRAM calibration flow. For EMCP DDR, the max supported DRAM frequency is 3600Mbps, so driver will do 3600Mbps data rate init. but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps, driver will do 3200Mbps data rate init.