build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27369 )
Change subject: soc/intel/basecode: Add support for updating microcode in the field ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_up... File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_up... PS17, Line 39: die("Failed to restart\n"); Prefer using '"%s...", __func__' to using 'restart', this function's name, in a string
https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_up... PS17, Line 74: printk (BIOS_ERR, "Slot ucode not found!\n"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_up... PS17, Line 84: printk (BIOS_ERR, "Staging area could not be initialized!\n"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_up... PS17, Line 104: printk (BIOS_ERR, "Staging area could not be mapped!\n"); space prohibited between function name and open parenthesis '('