[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint: Replace reg script with proper code

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43095 )

Change subject: sb/intel/lynxpoint: Replace reg script with proper code
......................................................................

sb/intel/lynxpoint: Replace reg script with proper code

Why use a Rube Goldberg machine to write and then read one register?

Change-Id: I282c12f162b5ae69c40729903c09ae81a14c9761
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43095
Tested-by: build bot (Jenkins) 
Reviewed-by: Tristan Corrick 
Reviewed-by: Arthur Heymans 
---
M src/southbridge/intel/lynxpoint/early_pch.c
1 file changed, 5 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Tristan Corrick: Looks good to me, approved

diff --git a/src/southbridge/intel/lynxpoint/early_pch.c b/src/southbridge/intel/lynxpoint/early_pch.c
index 586dd86..0d9d8e9 100644
--- a/src/southbridge/intel/lynxpoint/early_pch.c
+++ b/src/southbridge/intel/lynxpoint/early_pch.c
@@ -17,15 +17,6 @@
 #include <southbridge/intel/common/gpio.h>
 #endif

-const struct rcba_config_instruction pch_early_config[] = {
-	/* Enable IOAPIC */
-	RCBA_SET_REG_16(OIC, 0x0100),
-	/* PCH BWG says to read back the IOAPIC enable register */
-	RCBA_READ_REG_16(OIC),
-
-	RCBA_END_CONFIG,
-};
-
 int pch_is_lp(void)
 {
    u8 id = pci_read_config8(PCH_LPC_DEV, PCI_DEVICE_ID + 1);
@@ -103,8 +94,11 @@
    /* Enable SMBus for reading SPDs. */
    enable_smbus();

-	/* Early PCH RCBA settings */
-	pch_config_rcba(pch_early_config);
+	/* Enable IOAPIC */
+	RCBA16(OIC) = 0x0100;
+
+	/* PCH BWG says to read back the IOAPIC enable register */
+	(void) RCBA16(OIC);

/* Mainboard RCBA settings */
    pch_config_rcba(rcba_config);