Attention is currently required from: Evan Green, Ren Kuo, Paul Menzel, Aseda Aboagye, Tyler Wang.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60185 )
Change subject: mb/google/dedede/var/magolor: Add stylus pen function
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/dedede/variants/magolor/gpio.c:
https://review.coreboot.org/c/coreboot/+/60185/comment/c4a7232b_556cd9d1
PS2, Line 9:
Nit: Remove the extra line
https://review.coreboot.org/c/coreboot/+/60185/comment/74e31cf6_7ffa19ae
PS2, Line 12:
Nit: Remove the extra line
https://review.coreboot.org/c/coreboot/+/60185/comment/a1c1d928_11a77a6a
PS2, Line 17: *num = ARRAY_SIZE(gpio_table);
This Firmware target is applied to Magolor/Maglia/Magma/Maglet etc. Is pen stuffed on all boards. I believe not. If so, can you please apply this configuration only on the boards where pen is stuffed and mark this GPIO as PAD_NC on other boards.
Otherwise you might end up receiving spurious wakes due to this GPIO configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62489bb289b18f9aa0823005224eda3ef5218e03
Gerrit-Change-Number: 60185
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 20 Dec 2021 20:44:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment