Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/32730 )
Change subject: gma i2c: Rework GMBUS reset procedure
......................................................................
Patch Set 1:
Arthur, it would be interesting to test this on the
troubled g45 board(s). That is, with a broken port
detection, so it would try to talk to unconnected
ports.
I vaguely recall my x200 failing if unconnected ports are probed. I'll see what I can do.
Oh, nvm then. I thought it was some desktop board. I've
tested on an X200s which seems to have roughly the same
schematics.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/32730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: If737ffb35afa309de7746f0c16025b9598f69460
Gerrit-Change-Number: 32730
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 May 2019 11:12:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment