Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code
......................................................................
Patch Set 5:
(1 comment)
BTW, there i
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG@7
PS5, Line 7: soc/intel/common/block
BTW, I just noticed that there is already a reset.c in soc/intel/common: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/rese...
How does this common "reset" compare to that? Shouldn't the two be really combined into a single file?
Another thing: soc/intel/common/block is always used for an IP block. I don't think "reset" can be termed as an IP block. Shouldn't this code live directly under soc/intel/common as the reset.c file is already right now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 06:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment