Attention is currently required from: Arthur Heymans, Martin Roth, Julius Werner, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56122 )
Change subject: Makefile.inc: Add the x86 bootblock as a regular cbfs file
......................................................................
Patch Set 3:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56122/comment/e80d7b2e_581c6d64
PS3, Line 840: This top aligns files of type bootblock, assuming that only x86 uses those
Instead of making this assumption, maybe add a Kconfig option that's selected by x86? Up to you.
Would --xip not achieve the same without needing this extra code. That should do it for Intel.
I'm not exactly sure how that works for newer AMD systems. Isn't the bootblock cbfs file unnecessary here as the it's embedded inside the PSP image?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56122
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de9d7fedf1ae5a37a3310dd42eb07b44c030930
Gerrit-Change-Number: 56122
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 17:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment