Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31059 )
Change subject: src/mb/sifive/hifive-unleashed: initialize Gigabit Ethernet Controller
......................................................................
Patch Set 6:
(1 comment)
Thanks. Please drop the nsleep function and use mdelay instead.
Is this change tested on hw?
https://review.coreboot.org/#/c/31059/6/src/mainboard/sifive/hifive-unleashe...
File src/mainboard/sifive/hifive-unleashed/romstage.c:
https://review.coreboot.org/#/c/31059/6/src/mainboard/sifive/hifive-unleashe...
PS6, Line 56: static void nsleep(long nsec)
use mdelay instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31059
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I172dc518c9b48c122289bba5a65beece925410d4
Gerrit-Change-Number: 31059
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 24 Jan 2019 11:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment