Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48946 )
Change subject: mb/ocp/deltalake: Override DDR frequency limit via VPD variable
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48946/2/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/48946/2/src/mainboard/ocp/deltalake...
PS2, Line 85: if (vpd_gets(FSP_DIMM_FREQ, val_str, VPD_LEN, VPD_RW_THEN_RO)) {
Please refer to [CB:48908] and use vpd_get_int().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1232feae5090420d8fa42596b46f2d4dcaf9d635
Gerrit-Change-Number: 48946
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Dec 2020 17:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment