Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33635 )
Change subject: cpu/x86: use ALIGN_UP instead of ALIGN for better readability ......................................................................
cpu/x86: use ALIGN_UP instead of ALIGN for better readability
Change-Id: I0afb81740973a0c841ebe6cce984e135e5c395e6 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33635 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/cpu/x86/mirror_payload.c M src/cpu/x86/mp_init.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved
diff --git a/src/cpu/x86/mirror_payload.c b/src/cpu/x86/mirror_payload.c index 5f0493a..6da2164 100644 --- a/src/cpu/x86/mirror_payload.c +++ b/src/cpu/x86/mirror_payload.c @@ -42,7 +42,7 @@ alignment_diff = (intra_cacheline_mask & (uintptr_t)src); size += alignment_diff;
- size = ALIGN(size, cacheline_size); + size = ALIGN_UP(size, cacheline_size);
printk(BIOS_DEBUG, "Payload aligned size: 0x%zx\n", size);
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index b7b8fe2..9528149 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -321,7 +321,7 @@ module_size = rmodule_memory_size(&sipi_mod);
/* Align to 4 bytes. */ - module_size = ALIGN(module_size, 4); + module_size = ALIGN_UP(module_size, 4);
if (module_size > loc_size) { printk(BIOS_CRIT, "SIPI module size (%d) > region size (%d).\n",