Hello Patrick Rudolph, Aamir Bohra, V Sowmya, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34506
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Disable ACPI PM Timer due to power impact in S0ix ......................................................................
soc/intel/cannonlake: Disable ACPI PM Timer due to power impact in S0ix
BRANCH=none BUG=b:138152075 TEST=Build for cometlake board with the PmTimerDisabled policy in devicetree set to 1.
With PmTimerDisabled = 0
iotools mmio_read8 0xfe0018fc
0x00
With PmTimerDisabled = 1
iotools mmio_read8 0xfe0018fc
0x02
Bit 1: ACPI Timer Disable (ACPI_TIM_DIS): This bit determines whether the ACPI Timer is enabled to run. - 0: ACPI Timer is enabled - 1: ACPI Timer is disabled
Change-Id: I347c15c7b65fb4c19b9680f127980d4ddab8df51 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/soc/intel/cannonlake/fsp_params.c 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/34506/3