Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48749 )
Change subject: soc/intel/cnl: add panel and backlight configuration code ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48749/2/src/soc/intel/cannonlake/gr... File src/soc/intel/cannonlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/48749/2/src/soc/intel/cannonlake/gr... PS2, Line 3: #include <commonlib/helpers.h> : #include <device/device.h> : #include <device/mmio.h> : #include <device/pci_def.h> : #include <device/resource.h> : #include <drivers/intel/gma/i915.h> : #include <drivers/intel/gma/i915_reg.h> : #include <intelblocks/graphics.h> : #include <soc/ramstage.h> : #include <types.h> :
Do we really need all this?
commonlib/helpers.h: for rounding device/device.h: for struct device device/mmio.h: for mmio device/pci_def.h: for PCI_BASE_ADDRESS_0 device/resource.h: for probe_resource drivers/intel/gma/i915_reg.h: for the regs intelblocks/graphics.h: for struct i915_gpu_controller_info soc/ramstage.h: for soc_intel_cannonlake_config types.h: for types
drivers/intel/gma/i915.h: can be dropped