Hello Subrata Banik, Rizwan Qureshi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/26731 to look at the new patch set (#2). Change subject: mb/{google,intel}/*: Update IOAPIC GPIO pad configuration to include trigger mode ...................................................................... mb/{google,intel}/*: Update IOAPIC GPIO pad configuration to include trigger mode Update GPIO pad configuartion in IOAPIC invert mode to include RX level/edge Configuration. Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85dab Signed-off-by: Aamir Bohra <aamir.bohra@intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bip/gpio.c M src/mainboard/google/reef/variants/baseboard/gpio.c M src/mainboard/google/reef/variants/coral/gpio.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 6 files changed, 29 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/26731/2 -- To view, visit https://review.coreboot.org/26731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85dab Gerrit-Change-Number: 26731 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>