build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44669 )
Change subject: tests: Add lib/imd-test test case ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44669/1/tests/lib/imd-test.c File tests/lib/imd-test.c:
https://review.coreboot.org/c/coreboot/+/44669/1/tests/lib/imd-test.c@13 PS1, Line 13: void *memset(void * ptr, int value, size_t num); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44669/1/tests/lib/imd-test.c@69 PS1, Line 69: uint32_t align_up_pow2(uint32_t x) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/44669/1/tests/lib/imd-test.c@70 PS1, Line 70: return (IS_POWER_OF_2(x) ? x : 1 << (32 - __builtin_clz(x - 1))); return is not a function, parentheses are not required
https://review.coreboot.org/c/coreboot/+/44669/1/tests/lib/imd-test.c@73 PS1, Line 73: size_t max_entries(size_t root_size) { open brace '{' following function definitions go on the next line