[coreboot-gerrit] [S] Change in coreboot[main]: refactor: Consolidate bmp_logo_filename() logic

[Subrata Banik (Code Review)]

Attention is currently required from: Paz Zcharya.

Subrata Banik has posted comments on this change by Paz Zcharya. ( https://review.coreboot.org/c/coreboot/+/86566?usp=email )

Change subject: refactor: Consolidate bmp_logo_filename() logic
......................................................................

Patch Set 1:

(1 comment)

File src/lib/bmp_logo.c:

https://review.coreboot.org/c/coreboot/+/86566/comment/ee08189b_eb2d5afc?usp... :
PS1, Line 37: 	if (platform_is_low_battery_shutdown_needed())
            : 		logo_name = "low_battery.bmp";
> Oh, I see.
>
> Okay so should I re-upload that CL but with the safeguards in this file?

I don't think this CL is necessary. You probably want to move the low-battery logo to cros vendor code to keep the generic bmp_logo implementation clean. However, as I mentioned before, the idea is to decouple the cros splash from low-battery to allow non-cros device to use low-battery logo, so nothing needs to be done at this point imo.