Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47562 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 cpu voltage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47562/1/src/mainboard/ocp/deltalake...
PS1, Line 65: return 0x90; /* This will return 1.6V which is expected value for Delta Lake */
CB:43904 has done the same thing in src/arch/x86/smbios.c line 698, but I think it is much more clear to return 0x90 here.
Inconsistency would cause confusion. This patch and CB:43904 should match each other. Either option is fine, please make sure appropriate comment is added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ecbec8fb3dc79b8c3f3581d6193aade01bcd68e
Gerrit-Change-Number: 47562
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 18:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Tim Chu
Tim.Chu@quantatw.com
Gerrit-MessageType: comment