Attention is currently required from: Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49748 )
Change subject: nb/intel/gm45: Factor out {DMI,EP,MCH}BAR accessors
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File src/northbridge/intel/common/fixed_bars.h:
https://review.coreboot.org/c/coreboot/+/49748/comment/e196269a_dc1f3f98
PS5, Line 12: #define MCHBAR8(x) (*((volatile u8 *)(CONFIG_FIXED_MCHBAR_MMIO_BASE + (x))))
Without casting to `uintptr_t` first, won't this break x86_64?
File src/southbridge/intel/i82801ix/dmi_setup.c:
https://review.coreboot.org/c/coreboot/+/49748/comment/2e7e6b7b_54e998d3
PS5, Line 69: uintptr_t
Shouldn't need a cast.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49748
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia16ccc63dddebf938f4e9a7f5518e4d25d3e7e66
Gerrit-Change-Number: 49748
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 07 Feb 2021 19:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment