Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common/lpss: Add function to check for a LPSS controller
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34137/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34137/6//COMMIT_MSG@7
PS6, Line 7: soc/intel/common/lpss: Add function to check for a LPSS controller
how was it tested?
Why is it useful?
https://review.coreboot.org/c/coreboot/+/34137/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/6/src/soc/intel/common/block/...
PS6, Line 103: if (dev->path.type != DEVICE_PATH_PCI)
you need to verify the bus number, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5bb268fc581280bb1b87b6b175a0299a24a44a
Gerrit-Change-Number: 34137
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 22 Jul 2019 06:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment