10 May
2019
10 May
'19
8:15 p.m.
Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32717 )
Change subject: libpayload: classify all keyboards ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32717/1/payloads/libpayload/include/libpaylo... File payloads/libpayload/include/libpayload.h:
https://review.coreboot.org/#/c/32717/1/payloads/libpayload/include/libpaylo... PS1, Line 351: /* UNKNOWN was zero, but currently all are known */
No, please keep an UNKNOWN as zero. […]
I overlooked adding a "= 1" after usb so the numeric value remained the same (and avoids issues with placing dependencies on commits). I've brought back the UNKNOWN.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32717
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee6295dafadf7cb3da98b62f43b0e184b2b69b1e
Gerrit-Change-Number: 32717
Gerrit-PatchSet: 2
Gerrit-Owner: Matt Delco delco@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Matt Delco delco@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 10 May 2019 18:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment