Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32529 )
Change subject: SKL: add ACPI brightness control
......................................................................
Patch Set 4:
I should note that this patch was adapted from a series of commits from google's eve-campfire branch, and was a quick/dirty way for me to get ACPI brightness controls working for SKL/KBL devices. A better way would likely be to make use of the existing code under drivers/intel/gma, but would be a little more work.
There's also CB:31503 which provides the asl portion for the GMA driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b3df46de6da8b226c50de2fcc43356b3ee29cf2
Gerrit-Change-Number: 32529
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 May 2019 04:46:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment