Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31160 )
Change subject: soc/amd/stoneyridge: Reboot if missing MRC cache info
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31160/3/src/soc/amd/common/block/s3/s3_resum...
File src/soc/amd/common/block/s3/s3_resume.c:
https://review.coreboot.org/#/c/31160/3/src/soc/amd/common/block/s3/s3_resum...
PS3, Line 50: for (i = 0 ; i < 4 ; i++)
Address Paul's comment? […]
I took it more as a suggestion than a request. I don't think we have hard and fast rules on separation within a for() statement, and the above is always my preference. But meh, I don't want to argue over it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3cf2515f300decd3de198f7741660d95ee4c744
Gerrit-Change-Number: 31160
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Feb 2019 22:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment