[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: boot up sspm

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )

Change subject: google/kukui: boot up sspm
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... 
PS1, Line 44: unsigned char buf[BUF_SIZE];
> If move to sspm_boot, it will cause build error.

I think you mean declare that as auto variable inside function, which uses stack and would definitely run out of space.
> If use malloc(), the memory allocates fail .

Like it said, I think heap reserved there is less than 64K. There are few solutions:

1. If we think the sspm image file won't be compressed in future, just use cbfs_boot_map_with_leak .

2. If we think it'll save a lot of space by applying compression (and should be compressed), increase the heap in ramstage (src/soc/mediatek/mt8183/include/soc/memlayout.ld) may help.