Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41384 )
Change subject: device/pci_device: Add notion of "hidden" PCI devices ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@795 PS7, Line 795: hidden_pci_dev_ops Is this needed? Usually, we check all the pointers for NULL.
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@122... PS7, Line 1223: * ID as if there were no device there (0xffffffff). This is probably only true for a single device. IIRC, Intel has at least 4 different semantics for hidden but still active devices.
https://review.coreboot.org/c/coreboot/+/41384/7/src/device/pci_device.c@125... PS7, Line 1251: } If it resembles what another function would do, why not put it into a function of its own? The flow would need less comments and were easier to follow, I guess.