Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44916 )
Change subject: soc/intel/common/block: Add common support for USB4/Thunderbolt ......................................................................
Patch Set 10: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/44916/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44916/10//COMMIT_MSG@10 PS10, Line 10: USB4/Thunderbolt ports DMA device for the USB4 router/controller?
https://review.coreboot.org/c/coreboot/+/44916/10/src/soc/intel/common/block... File src/soc/intel/common/block/usb4/Kconfig:
https://review.coreboot.org/c/coreboot/+/44916/10/src/soc/intel/common/block... PS10, Line 4: depends on HAVE_ACPI_TABLES Since the driver is doing more than just generating ACPI tables, this is probably not required?
https://review.coreboot.org/c/coreboot/+/44916/10/src/soc/intel/common/block... File src/soc/intel/common/block/usb4/usb4.c:
https://review.coreboot.org/c/coreboot/+/44916/10/src/soc/intel/common/block... PS10, Line 3: #include <device/device.h> Why was this dropped?
https://review.coreboot.org/c/coreboot/+/44916/10/src/soc/intel/common/block... PS10, Line 33: acpigen_write_scope(acpi_device_path(dev)); I know we probably still have some hard-coded references in DSDT, but eventually we should move the generation of device to this function as well (acpi_device_write_pci_dev(dev)).