[coreboot-gerrit] Change in coreboot[master]: cpu/intel/car: Skip stack integrity check if FSP_USES_CB_STACK is enable

[Nathaniel L Desimone (Code Review)]

Nathaniel L Desimone has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35165 )

Change subject: cpu/intel/car: Skip stack integrity check if FSP_USES_CB_STACK is enable
......................................................................

Patch Set 3:
> Patch Set 3:
> > I must confess that I don't know a whole lot about coreboot's stack allocation mechanisms, but at a basic level it makes sense to me that if the FSP MemoryInit() runs on the same stack as coreboot then the coreboot stack will need to be larger. For a full memory training FSP uses approximately 128KB, which matches up with the new value for the DCACHE_BSP_STACK_SIZE kcfg option. That said, I have no idea if this is the best way to implement this and defer to others for that feedback.
>
> But the FSP integration guide for CML mentions 160KiB without shared stack i.e. with FSP2.0. Nothing is captured for FSP 2.1. What are the size requirements for a) stack b) hob temporary space for CML with the shared stack for FSP and bootloader?

Sounds like the Comet Lake Integration Guide has gotten a little stale then. I'm out of office this week but I'll follow up next week.