Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: [RFC] Replace strapping_id entries with new board configuration entry ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46605/5/payloads/libpayload/include... File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/46605/5/payloads/libpayload/include... PS5, Line 263: struct cb_strapping_id {
Remove?
Done
https://review.coreboot.org/c/coreboot/+/46605/5/payloads/libpayload/include... PS5, Line 326: dram_id
Since we're keeping the name ram_code in sysinfo (and we probably should, since external payloads ma […]
Fair point, makes discovery of it easier too.
https://review.coreboot.org/c/coreboot/+/46605/5/payloads/libpayload/include... File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/46605/5/payloads/libpayload/include... PS5, Line 110: #define UNDEFINED_STRAPPING_ID_64 (~(uint64_t)0)
I think you can just change the existing macro to 64-bit, it will auto-convert down to ~0 when assig […]
I tried that, gcc wasn't happy: ``` In file included from src/lib/coreboot_table.c:12: src/lib/coreboot_table.c: In function 'board_id': src/include/boardid.h:8:36: error: conversion from 'long long unsigned int' to 'uint32_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] #define UNDEFINED_STRAPPING_ID ~((uint64_t)0) ^ src/lib/coreboot_table.c:213:41: note: in expansion of macro 'UNDEFINED_STRAPPING_ID' __weak uint32_t board_id(void) { return UNDEFINED_STRAPPING_ID; }
```