Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )
Change subject: sb/intel/common/firmware: add ifd update option ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 31: -new
`-new` doesn't carry much information, how about `descriptor-newlayout.bin`? […]
your right. Due to the fact that the idtool creates a new descriptor at the same path as the old one, it have to be copied to the build path. I will name the target 'descriptor.bin' and will remove the copy process, as soon as https://review.coreboot.org/c/coreboot/+/38828 is merged.
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 32: $(IFDTOOL)
Note that they will need $(strip_quotes ) beforehand.
Done
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 34: $(CONFIG_IFD_BIN_PATH)
Could use $< if you make it the first prerequisite.
Done
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 39: $(obj)/descriptor-new.bin
Use $@ here to make clear that it's the target.
Done
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 40: endif
Please remove $(obj)/descriptor-old. […]
Done