Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32791 )
Change subject: soc/intel/cannonlake: Configure SPI CS parameters in FSP UPD. ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32791/6/src/soc/intel/cannonlake/fsp_params.... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/32791/6/src/soc/intel/cannonlake/fsp_params.... PS6, Line 137: *defaultcs = 0; : *enable = 1; Add NULL-checks and you can use the same function in both cases