Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35018 )
Change subject: soc/amd/common/block: Create new SPI code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35018/2/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/fch_spi.h:
https://review.coreboot.org/c/coreboot/+/35018/2/src/soc/amd/common/block/in...
PS2, Line 94: crop_chunk
Would conflict with same function at drivers/spi/spi_flash. […]
No answer, changed to fch_spi_crop().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id293fb9b2da84c4206c7a1341b64e83fc0b8d71d
Gerrit-Change-Number: 35018
Gerrit-PatchSet: 5
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Sep 2019 17:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment