Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 14:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... PS10, Line 9: gpio_table
override_gpio_table
Done
https://review.coreboot.org/c/coreboot/+/42301/10/src/mainboard/google/volte... PS10, Line 170: gpio_table
You need to change this to override_gpio_table. Please build it locally before submitting.
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/memory.c:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 5: malefor_memcfg
delbin_memcfg ?
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 59: malefor_memcfg
delbin_memcfg ?
Done
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 54: device pci 1f.3 on : end
1f.3 is HD audio, i don't think you want to turn it off. […]
Done
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 15: end we usually put the "end" on the same line as the "device" when there's nothing in the block.
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 24: probe AUDIO MAX98373_ALC5682I_I2S the probe statements for the AMPs can go away as well.
https://review.coreboot.org/c/coreboot/+/42301/14/src/mainboard/google/volte... PS14, Line 54: 15.2 this is I2C2, did you mean 19.1?
if you don't have anything on i2c2, you can turn it off here as it's enabled in devicetree.cb. looks like you have pch_i2c2_misc routed somewhere, so probably keep it on.