24 Dec
2019
24 Dec
'19
9:50 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37392 )
Change subject: cpu/x86/smm/ssm_stub: Add x86_64 support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37392/2/src/cpu/x86/smm/smm_stub.S File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/37392/2/src/cpu/x86/smm/smm_stub.S@... PS2, Line 206: %eax
yes, 32bit operands invalidate the upper bits. […]
c_handler is an u32 (.long in assembly) and thus it lies < 4G
--
To view, visit https://review.coreboot.org/c/coreboot/+/37392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26300492e4be62ddd5d80525022c758a019d63a1
Gerrit-Change-Number: 37392
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
Gerrit-CC: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Tue, 24 Dec 2019 09:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment