Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50324 )
Change subject: soc/intel/xeon_sp/include/soc/acpi_asl.h: Convert to ASL 2.0 ......................................................................
Patch Set 1:
(4 comments)
File src/soc/intel/xeon_sp/include/soc/acpi_asl.h:
https://review.coreboot.org/c/coreboot/+/50324/comment/8484058c_c42c97ab PS1, Line 50: IRQ0 = 1 << (^^PIR##id & ^^IREM) \ need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/50324/comment/146f1da9_86fc139f PS1, Line 62: If (^^PIR##id & ^^IREN) { \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/50324/comment/2fd50566_7c963bb7 PS1, Line 62: If (^^PIR##id & ^^IREN) { \ need consistent spacing around '^' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/50324/comment/a8e1c256_ffa71dd9 PS1, Line 70: ^^PIR##id |= ^^IREN \ need consistent spacing around '^' (ctx:WxO)