build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37437 )
Change subject: mb/intel/tglrvp: Do initial mainboard commit ......................................................................
Patch Set 1:
(120 comments)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 1: config BOARD_INTEL_BASEBOARD_TGLRVP trailing whitespace
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 31: {-1, ACTIVE_HIGH, 0,"EC in RW"}, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 1: 23 11 11 0E 1B 21 F0 08 00 40 00 00 0A 01 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 2: 00 00 05 0F 92 54 01 00 8A 00 90 A8 90 C0 08 60 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 3: 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 8: 00 00 00 00 00 00 00 00 00 00 00 92 00 A7 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 9: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 21: 00 00 00 00 00 56 00 00 00 20 20 20 20 20 20 20 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 22: 20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 23: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.hex:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 1: 23 10 11 0E 15 19 95 08 00 40 00 00 02 21 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 2: 48 00 05 FF 92 55 00 00 8C 00 90 A8 90 90 06 D0 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 3: 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 8: 00 00 00 00 00 00 00 00 00 00 00 00 7F 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 9: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 21: 00 00 00 00 00 55 00 00 00 20 20 20 20 20 20 20 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 22: 20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 23: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 24: PAD_CFG_GPO(GPP_A13 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 25: PAD_CFG_GPO(GPP_B15 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 26: PAD_CFG_GPO(GPP_C22 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 27: PAD_CFG_GPI_SCI(GPP_C23 , NONE, DEEP, LEVEL, INVERT), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 28: PAD_CFG_GPI_SCI(GPP_H19 , NONE, DEEP, LEVEL, INVERT), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 37: PAD_CFG_GPO(GPP_H0 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 43: PAD_CFG_GPO(GPP_R6 , 0, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 47: PAD_CFG_GPO(GPP_C5 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 50: PAD_CFG_GPO(GPP_H1 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 51: PAD_CFG_GPI_APIC(GPP_C8 , NONE, PLTRST, EDGE_SINGLE, INVERT), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 55: PAD_CFG_GPO(GPP_E8 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 58: PAD_CFG_GPI_SCI(GPP_C14 , NONE, DEEP, LEVEL, INVERT), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 61: PAD_CFG_GPO(GPP_E22 , 0, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 62: PAD_CFG_GPO(GPP_E23 , 1, PLTRST), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 74: PAD_CFG_GPI_SCI(GPP_C9 , NONE, DEEP, LEVEL, INVERT), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 97: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 97: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 102: *num = ARRAY_SIZE(cros_gpios); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 102: *num = ARRAY_SIZE(cros_gpios); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 103: return cros_gpios; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 103: return cros_gpios; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 32: const void *dq_map; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 32: const void *dq_map; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 33: size_t dq_map_size; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 33: size_t dq_map_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 34: const void *dqs_map; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 34: const void *dqs_map; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 35: size_t dqs_map_size; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 35: size_t dqs_map_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 36: u16 rcomp_resistor; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 36: u16 rcomp_resistor; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 37: const void *rcomp_target; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 37: const void *rcomp_target; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 38: size_t rcomp_target_size; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 38: size_t rcomp_target_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 48: #else trailing whitespace
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 24: return 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 24: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 32: { 15, 8, 9, 14, 12, 11, 10, 13 }}, // Byte 1 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 34: { 3, 4, 7, 0, 6, 1, 5, 2 }}, // Byte 3 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 36: { 11, 10, 12, 13, 8, 9, 14, 15 }}, // Byte 5 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 38: { 4, 7, 3, 2, 1, 6, 0, 5 }}, // Byte 7 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 41: { 4, 5, 6, 7, 3, 2, 0, 1 }}, // Byte 1 ChB! space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 43: { 9, 8, 10, 11, 14, 15, 13, 12 }}, // Byte 3 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 45: { 10, 13, 12, 11, 14, 9, 15, 8 }}, // Byte 5 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 47: { 3, 4, 1, 2, 6, 0, 5, 7 }} // Byte 7 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 61: { 2, 3, 1, 0, 7, 4, 5, 6 }}, // Byte 1 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 63: { 2, 3, 1, 0, 6, 5, 7, 4 }}, // Byte 3 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 65: { 0, 1, 2, 3, 4, 7, 6, 5 }}, // Byte 5 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 67: { 2, 3, 0, 1, 5, 4, 7, 6 }}, // Byte 7 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 70: { 0, 1, 2, 3, 7, 4, 5, 6 }}, // Byte 1 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 72: { 1, 7, 0, 6, 3, 5, 2, 4 }}, // Byte 3 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 74: { 0, 1, 7, 6, 3, 2, 5, 4 }}, // Byte 5 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/37437/1/src/mainboard/intel/tglrvp/... PS1, Line 76: { 15, 14, 10, 11, 12, 9, 8, 13 }} // Byte 7 space required after that close brace '}'