Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add Dell OptiPlex 9010 SFF support ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/40351/5/Documentation/mainboard/del... File Documentation/mainboard/dell/optiplex_9010.md:
https://review.coreboot.org/c/coreboot/+/40351/5/Documentation/mainboard/del... PS5, Line 35: | smsc_sch5545.bin | SMSC SCH5545 EC | Optional |
Could you please add a section, how to extract this, and where it is located?
Added below.
https://review.coreboot.org/c/coreboot/+/40351/5/Documentation/mainboard/del... PS5, Line 75: Internal programming will not work when migrating from original UEFI firmware.
Didn’t older vendor firmware versions have a bug, that you could write after one suspend/resume cycl […]
Haven't tried that, but kind of likely that S3 bootscript does not set protected range registers on resume.
https://review.coreboot.org/c/coreboot/+/40351/5/Documentation/mainboard/del... PS5, Line 101: seem
seems
Done
https://review.coreboot.org/c/coreboot/+/40351/5/Documentation/mainboard/del... PS5, Line 119: Linux
What version?
Done
https://review.coreboot.org/c/coreboot/+/40351/5/Documentation/mainboard/del... PS5, Line 140: - Booting Debian, Ubuntu, QubesOS
What versions?
Done
https://review.coreboot.org/c/coreboot/+/40351/5/src/mainboard/dell/optiplex... File src/mainboard/dell/optiplex_9010/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40351/5/src/mainboard/dell/optiplex... PS5, Line 19: sch5545_ecfw.bin
Add a Kconfig option for configuring the path?
Done