[coreboot-gerrit] Change in coreboot[master]: mb/google/brya: Apply fw_config_gpio_override API

[Nick Vaccaro (Code Review)]

Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, EricR Lai, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61114 )

Change subject: mb/google/brya: Apply fw_config_gpio_override API
......................................................................

Patch Set 8:

(1 comment)

File src/mainboard/google/brya/variants/anahera4es/fw_config.c:

https://review.coreboot.org/c/coreboot/+/61114/comment/dd2de180_aff5d561 
PS8, Line 8: static const struct pad_config dmic_enable_pads[] = {
           : 	PAD_CFG_NF(GPP_R4, NONE, DEEP, NF3),	/* DMIC_CLK0 */
           : 	PAD_CFG_NF(GPP_R5, NONE, DEEP, NF3),	/* DMIC_DATA0 */
           : 
           : };
           : 
           : 
Why did these arrays need to change from being constant structs?  Because of the add_fw_override_pad() prototype?

I think it might be better to change gpio_override() to take a "const struct pad_info fw_config_gpio" as it's second parameter given it doesn't change that structure anyway and allow these constant structures to remain constant.

Thoughts?