Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: cpu/x86: Make MP init timeout configurable
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG@10
PS1, Line 10: Xeon scalable processor, the timeout needs to be adjusted.
Are you saying that multi socket cpus coming online takes 10 secs? I don't see a reason aside from " […]
10 seconds is an extreme number. However, the original 1 second is definitely not enough. Also the number depends on platform design, such as how far it is from one socket to another socket, and how many sockets there are (8 socket servers are being worked on in the industry).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc079fc6aa8641d4ac8d8e726899b6c8d055052e
Gerrit-Change-Number: 38546
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jan 2020 20:31:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment