[coreboot-gerrit] Change in coreboot[master]: arch/x86/smbios: Update SMBIOS type 0 ec version

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45138 )

Change subject: arch/x86/smbios: Update SMBIOS type 0 ec version
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45138/2/src/drivers/ipmi/ipmi_kcs_o... 
File src/drivers/ipmi/ipmi_kcs_ops.c:

https://review.coreboot.org/c/coreboot/+/45138/2/src/drivers/ipmi/ipmi_kcs_o... 
PS2, Line 283: ((bmc_revision_major / 16) * 10) + (bmc_revision_major % 16)
> The value received from OpenBMC is hexadecimal, however it should be decimal. […]

0x33 is not decimal 33, Are you saying that OpenBMC has a bug? In this case, we need to make it a weak function, and do the bug workaround in mainboard code. In the mean time, we need OpenBMC to fix the bug.
Sounds like the first nibble is major version, while second nibble is minor version, so we should use bit shift (instead of arithmetic operation) to get them. In this case, OpenBMC does not have a bug.