Hello Kyösti Mälkki, Paul Menzel, David Hendricks, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33237
to look at the new patch set (#2).
Change subject: device,nb/amd: Deduplicate add_more_links() ......................................................................
device,nb/amd: Deduplicate add_more_links()
This function is duplicated in many AMD northbridge files, and all the definitions have started to diverge somewhat. This moves a single copy into device utils and deletes the rest. The function definition from nb/amd/amdfam10 was chosen to be kept, since it contains several fixes from commit 59d609217b (AMD fam10: Fix add_more_links) that the others don't have.
For the ease of diffing, the checkpatch lints and other small cleanups will be done in a follow-up patch.
Change-Id: I5ea73126092449db3f18e19ac0660439313072de Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/device/device_util.c M src/include/device/device.h M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c M src/northbridge/amd/amdfam10/northbridge.c M src/northbridge/amd/pi/00630F01/northbridge.c M src/northbridge/amd/pi/00660F01/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c 8 files changed, 37 insertions(+), 216 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/33237/2