Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35554 )
Change subject: hatch: Create puff variant
......................................................................
Patch Set 1:
(1 comment)
I presume there is no issue with making the name 'Puff' public at this point, since some puff setup has already gone into the chromeos repo.
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/...
PS1, Line 1: cannonlake
Should this be cometlake?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35554
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32c9d8bf41e2895bca2184558e8c1059659e6eb9
Gerrit-Change-Number: 35554
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Sep 2019 11:16:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment