Attention is currently required from: Francois Toguo Fotso, Tim Wawrzynczak, Patrick Rudolph.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59355 )
Change subject: soc/intel/alderlake: Save/restore BAR registers when extract cpu crashlog
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
Patchset:
PS6:
Hi Tim,
Instead of removing tmp bar assignment, i would like to do save/restore BAR0/BAR1 before and after crashlog capture.
It's just in case the bar is not assigned by CB some day in the future and also prevent it occupy pmc mmio in later bios boot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e6772be51ec4f26ef31fed6cb2bddef8ffc6be
Gerrit-Change-Number: 59355
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 18 Nov 2021 06:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment