build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26800 )
Change subject: util/sconfig: Add support for multiple device instances ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@564 PS3, Line 564: if (ptr->children || device_has_instance(ptr)) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@668 PS3, Line 668: fprintf(fil, "\t.pci_irq_info[%d].ioapic_irq_pin = %d,\n", line over 80 characters
https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@672 PS3, Line 672: fprintf(fil, "\t.pci_irq_info[%d].ioapic_dst_id = %d,\n", line over 80 characters
https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@692 PS3, Line 692: fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore); line over 80 characters
https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@707 PS3, Line 707: else if(ptr->children) space required before the open parenthesis '('