Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37177 )
Change subject: sb/amd/{agesa,pi}/hudson: enable support for AMD common ACPIMMIO blocks ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37177/1/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37177/1/src/mainboard/pcengines/apu... PS1, Line 16: #include <amdblocks/acpimmio.h>
Why is the header added with no other code? Can the mainboard code be factored out into a separate c […]
Prototypes from one of the headers below was moved into this file.
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... PS1, Line 4: CPPFLAGS_common += -I$(src)/southbridge/amd/agesa/hudson/include
Lets not introduce include/ there.
Done
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... PS1, Line 5: * Copyright 2017 Google Inc.
I guess this is copy from somewhere?
Done
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... PS1, Line 25: #include <amdblocks/acpimmio_map.h>
Why?
Done
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/smbus.c:
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/agesa/h... PS3, Line 19: #include <amdblocks/acpimmio.h>
not needed?
Done
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/pi/huds... PS1, Line 25: #include <amdblocks/acpimmio_map.h>
Why ?
Done
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/smbus.c:
https://review.coreboot.org/c/coreboot/+/37177/3/src/southbridge/amd/pi/huds... PS3, Line 19: #include <amdblocks/acpimmio.h>
Not needed?
Done