Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40322 )
Change subject: soc/amd/picasso: Cleanup legacy UART config ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40322/2//COMMIT_MSG@18 PS2, Line 18: BUG=b:143283592
nit: Are the two bug IDs intended to be here? I've no idea of what they are about
this is intended. these are for the chromium downstream bugtracker and there is the original bug and the issue regarding the upstreaming. When the patch lands in upstream and gets pulled back into some downstream branch, this will add a comment in the internal issue tracker. so yeah, for upstream this has no practical use, but in downstream this is very useful