Attention is currently required from: Arthur Heymans, Chen, Gang C, Fred Reitberger, Jason Glenesk, Jincheng Li, Jérémy Compostella, Martin L Roth, Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78328?usp=email )
Change subject: device/device.h: Drop multiple links ......................................................................
Patch Set 10:
(12 comments)
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/83eab2b7_0c0ecf60 : PS10, Line 362: if (link && link->reset_needed) { Or `continue;` if not.
https://review.coreboot.org/c/coreboot/+/78328/comment/233c4af7_ac24d9a6 : PS10, Line 489: if (dev_root.link_list) Other functions seem to imply this.
https://review.coreboot.org/c/coreboot/+/78328/comment/1ecb7a8b_23243d0e : PS10, Line 558: if (dev_root.link_list) Other functions seem to imply this.
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/9e6efb87_066154ea : PS10, Line 550: search_bus_resources(curdev->link_list, type_mask, type, Missing NULL-check.
File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/2848c726_a5bc9011 : PS10, Line 41: Missing NULL-check.
https://review.coreboot.org/c/coreboot/+/78328/comment/154450d7_e0cb27e2 : PS10, Line 78: Then, link_list buses Was this on purpose? Looks a bit like something went wrong undoing the renaming?
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/78328/comment/7162398c_1e0a1e53 : PS10, Line 239: } Probably shouldn't be inline anymore.
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/ac2dd216_cbc258c2 : PS10, Line 797: const struct bus *bus = parent->bus; NULL check?
https://review.coreboot.org/c/coreboot/+/78328/comment/3b90a65b_6b789616 : PS10, Line 1178: if (bus->children) Or `assert(ptr->bus && ptr->bus->children);`. It seems to be checked before the call.
https://review.coreboot.org/c/coreboot/+/78328/comment/0b072d27_f053a36d : PS10, Line 1330: bus && bus->children Or dev_has_children(). We should either use it everywhere or could also drop it.
https://review.coreboot.org/c/coreboot/+/78328/comment/574353ed_56b3cce1 : PS10, Line 1789: buses *bus
File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/78328/comment/b6cb876f_bd6ea45c : PS10, Line 157: struct bus *last_bus; Drop