Attention is currently required from: Arthur Heymans, Chen, Gang C, Fred Reitberger, Jason Glenesk, Jincheng Li, Jérémy Compostella, Martin L Roth, Matt DeVillier.
12 comments:
File src/device/device.c:
Patch Set #10, Line 362: if (link && link->reset_needed) {
Or `continue;` if not.
Patch Set #10, Line 489: if (dev_root.link_list)
Other functions seem to imply this.
Patch Set #10, Line 558: if (dev_root.link_list)
Other functions seem to imply this.
File src/device/device_util.c:
Patch Set #10, Line 550: search_bus_resources(curdev->link_list, type_mask, type,
Missing NULL-check.
File src/device/root_device.c:
Missing NULL-check.
Patch Set #10, Line 78: Then, link_list buses
Was this on purpose? Looks a bit like something went wrong undoing the renaming?
File src/include/device/device.h:
Probably shouldn't be inline anymore.
File util/sconfig/main.c:
Patch Set #10, Line 797: const struct bus *bus = parent->bus;
NULL check?
Patch Set #10, Line 1178: if (bus->children)
Or `assert(ptr->bus && ptr->bus->children);`. It seems to be checked before
the call.
Patch Set #10, Line 1330: bus && bus->children
Or dev_has_children(). We should either use it everywhere or could also drop it.
Patch Set #10, Line 1789: buses
*bus
File util/sconfig/sconfig.h:
Patch Set #10, Line 157: struct bus *last_bus;
Drop
To view, visit change 78328. To unsubscribe, or for help writing mail filters, visit settings.